Add support for Ubuntu24 #2880
Merged
Add support for Ubuntu24 #2880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgreebe
force-pushed
the
ubuntu-support
branch
from
7fae24b to
e25a9f3
Compare
himani2411
reviewed
Feb 19, 2025
| action_class do | ||
| def armpl_platform | ||
| "Ubuntu-#{node['platform_version']}" | ||
| "Ubuntu-22.04" |
Contributor
There was a problem hiding this comment.
Nitpicks:
Rename the file to *22+.rband add a comment that armpl_plaform is hardcoded toUbuntu-22.04` as that the folder in s3 which we look for the tar file
himani2411
reviewed
Feb 19, 2025
| # frozen_string_literal: true | ||
|
|
||
| # | ||
| # Copyright:: 2023 Amazon.com, Inc. or its affiliates. All Rights Reserved. |
himani2411
reviewed
Feb 19, 2025
| # http://aws.amazon.com/apache2.0/ | ||
| # | ||
| # or in the "LICENSE.txt" file accompanying this file. | ||
| # This file is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, express or implied. |
Contributor
There was a problem hiding this comment.
Nitpick on renaming the file to ubuntu22+
himani2411
reviewed
Feb 19, 2025
|
|
||
| provides :nvidia_driver, platform: 'ubuntu' do |node| | ||
| node['platform_version'].to_i == 22 | ||
| node['platform_version'].to_i >= 22 |
himani2411
reviewed
Feb 19, 2025
kitchen.ec2.yml
Outdated
| driver: | ||
| <% if ENV['KITCHEN_UBUNTU2404_AMI'] %> | ||
| # Use the Ubuntu 22 AMI most similar to the base AMI used to build the ParallelCluster image | ||
| image_id: <%= ENV['KITCHEN_UBUNTU2204_AMI'] %> |
Contributor
There was a problem hiding this comment.
It should be KITCHEN_UBUNTU2404_AMI
hgreebe
force-pushed
the
ubuntu-support
branch
from
e25a9f3 to
d69c82d
Compare
himani2411
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.